Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRDStreamSource Dangling Reference Fix : 12_3_X #37678

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

Sam-Harper
Copy link
Contributor

PR description:

This PR fixes a dangling reference in FRDStreamSource when reading multiple error stream files. The fileNames() function returns std::vectorstd::string which the code sets iterators to which then instantly become invalid as they are dangling.

This keeps an internal copy of the returned std::vector and sets the iterators to that.

PR validation:

It now successfully processes events in multiple files rather than spewing random garbage to the terminal.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37677

It would make life easier for FOG to have this in CMSSW_12_3_X as this will simplify our lives when dealing with error stream events during commissioning.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2022

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_12_3_X.

It involves the following packages:

  • EventFilter/Utilities (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor

@cmsbuild please test

@missirol
Copy link
Contributor

backport of #37677

(just adding the label)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d017af/24210/summary.html
COMMIT: 67781c4
CMSSW: CMSSW_12_3_X_2022-04-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37678/24210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697099
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor

type bugfix

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 23343c9 into cms-sw:CMSSW_12_3_X Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants