-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRDStreamSource Dangling Reference Fix : 12_3_X #37678
FRDStreamSource Dangling Reference Fix : 12_3_X #37678
Conversation
A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_12_3_X. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild please test |
backport of #37677 (just adding the label) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d017af/24210/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
type bugfix |
+1 |
PR description:
This PR fixes a dangling reference in FRDStreamSource when reading multiple error stream files. The fileNames() function returns std::vectorstd::string which the code sets iterators to which then instantly become invalid as they are dangling.
This keeps an internal copy of the returned std::vector and sets the iterators to that.
PR validation:
It now successfully processes events in multiple files rather than spewing random garbage to the terminal.
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #37677
It would make life easier for FOG to have this in CMSSW_12_3_X as this will simplify our lives when dealing with error stream events during commissioning.