Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect cast in SiStripGainsPCLHarvester #37660

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Fix incorrect cast in SiStripGainsPCLHarvester #37660

merged 1 commit into from
Apr 23, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The type returned from ProjectionY is a TH1D, not a TH1F.
Used safer dynamic_cast rather than dangerous C style cast.
This was caught by the UBSAN report.

PR validation:

Code compiles.

@Dr15Jones
Fix incorrect cast in SiStripGainsPCLHarvester
436e780 
The type returned from ProjectionY is a TH1D, not a TH1F.
This was caught by the UBSAN report.
@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Apr 22, 2022
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37660/29462

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • CalibTracker/SiStripChannelGain (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @alesaggio, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55a7a0/24145/summary.html
COMMIT: 436e780
CMSSW: CMSSW_12_4_X_2022-04-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37660/24145/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 1343.01343.0_ZpMM_2250_13+ZpMM_2250_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZpMM_2250_13+ZpMM_2250_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
  • 1344.01344.0_ZpEE_2250_13+ZpEE_2250_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZpEE_2250_13+ZpEE_2250_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
  • 1341.01341.0_RSKKGluon_m3000GeV_13+RSKKGluon_m3000GeV_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_RSKKGluon_m3000GeV_13+RSKKGluon_m3000GeV_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
Expand to see more relval errors ...
  • 1340.0
  • 1339.0
  • 1345.0
  • 1347.0
  • 1348.0
  • 1349.0
  • 1350.0
  • 1351.0
  • 1352.0
  • 1353.0
  • 1354.0
  • 1355.0
  • 1364.0
  • 1365.0
  • 1366.0
  • 134.0
  • 134.99601
  • 134.99602
  • 134.99603
  • 134.99901
  • 144.6
  • 139901.0
  • 139902.0
  • 13992501.0
  • 13992502.0
  • 200.0
  • 202.0
  • 203.0
  • 205.0
  • 11024.2
  • 25200.0
  • 25202.0
  • 25202.1
  • 25202.2
  • 25203.0
  • 25204.0
  • 25205.0
  • 25206.0
  • 25207.0
  • 25208.0
  • 25209.0
  • 25214.0
  • 50200.0
  • 50202.0
  • 50203.0
  • 50204.0
  • 50205.0
  • 50206.0
  • 50207.0
  • 50208.0
  • 1000.0
  • 1001.0
  • 1001.2
  • 1002.0
  • 1003.0
  • 1004.0
  • 1010.0
  • 1020.0
  • 1030.0
  • 1040.0
  • 1040.1
  • 1041.0
  • 1042.0
  • 1102.0
  • 4000.0
  • 4001.0
  • 4002.0
  • 4003.0
  • 10001.0
  • 10002.0
  • 10003.0
  • 10004.0
  • 10005.0
  • 10006.0
  • 10007.0
  • 10008.0
  • 10009.0
  • 10023.0
  • 10024.0
  • 10024.1
  • 10024.2
  • 10024.3
  • 10024.4
  • 10024.5
  • 10025.0
  • 10026.0
  • 10042.0
  • 10059.0
  • 10071.0
  • 10224.0
  • 10225.0
  • 10424.0
  • 10801.0
  • 10802.0
  • 10803.0
  • 10804.0
  • 10805.0
  • 10806.0
  • 10807.0
  • 10808.0
  • 10809.0
  • 10823.0
  • 10824.0
  • 10824.1
  • 10824.5
  • 10824.501
  • 10824.505
  • 10824.511
  • 10824.521
  • 10824.6
  • 10824.8
  • 10825.0
  • 10826.0
  • 10842.0
  • 10842.501
  • 10842.505
  • 10859.0
  • 10871.0
  • 11024.0
  • 11024.6
  • 11025.0
  • 11224.0
  • 11224.6
  • 11601.0
  • 11602.0
  • 11603.0
  • 11604.0
  • 11605.0
  • 11606.0
  • 11607.0
  • 11608.0
  • 11609.0
  • 11630.0
  • 11634.0
  • 11634.1
  • 11634.24
  • 11634.5
  • 11634.501
  • 11634.505
  • 11634.511
  • 11634.521
  • 11634.7
  • 11634.91
  • 11640.0
  • 11643.0
  • 11646.0
  • 11650.0
  • 11650.501
  • 11650.505
  • 11723.17
  • 11725.0
  • 11834.0
  • 11834.13
  • 11834.21
  • 11834.24
  • 11834.99
  • 11846.0
  • 11925.0
  • 12034.0
  • 12434.0
  • 12634.0
  • 12634.99
  • 12834.0
  • 13034.0
  • 13034.99
  • 23234.0
  • 23234.21
  • 23434.21
  • 23434.99
  • 23434.9921
  • 23434.999
  • 34634.0
  • 35034.0
  • 39434.0
  • 39434.103
  • 39434.21
  • 39434.5
  • 39434.501
  • 39434.502
  • 39434.75
  • 39434.9
  • 39496.0
  • 39500.0
  • 39634.114
  • 39634.21
  • 39634.99
  • 39634.9921
  • 39634.999
  • 250200.0
  • 250200.17
  • 250200.18
  • 250202.0
  • 250202.1
  • 250202.17
  • 250202.171
  • 250202.172
  • 250202.18
  • 250202.181
  • 250202.2
  • 250202.3
  • 250202.4
  • 250202.5
  • 250203.0
  • 250203.17
  • 250203.18
  • 250204.0
  • 250204.17
  • 250204.18
  • 250205.0
  • 250205.17
  • 250205.18
  • 250206.0
  • 250206.17
  • 250206.18
  • 250206.181
  • 250207.0
  • 250207.17
  • 250207.18
  • 250208.17
  • 250208.18
  • 500200.0
  • 500202.0
  • 500203.0
  • 500204.0
  • 500205.0
  • 500206.0
  • 500207.0

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55a7a0/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695398
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 23, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55a7a0/24149/summary.html
COMMIT: 436e780
CMSSW: CMSSW_12_4_X_2022-04-22-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37660/24149/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55a7a0/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695398
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 23, 2022

+alca

  • tests pass
  • technical PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Apr 23, 2022

type bug-fix

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3a3808 into cms-sw:master Apr 23, 2022
This was referenced Apr 24, 2022
Merged
Merged
Merged
Merged
@Dr15Jones Dr15Jones deleted the properTypeInSiStripGainsPCLHarvester branch April 25, 2022 13:32
@cmsbuild cmsbuild mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved bug-fix code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @tvami @perrotta