-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636
Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29426
|
A new Pull Request was created by @alexsr-98 for master. It involves the following packages:
@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
if ((*muons)[i].isGlobalMuon() == 1) { | ||
tkref = (*muons)[i].globalTrack(); | ||
} else { | ||
tkref = (*muons)[i].muonBestTrack(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ((*muons)[i].isGlobalMuon() == 1) { | |
tkref = (*muons)[i].globalTrack(); | |
} else { | |
tkref = (*muons)[i].muonBestTrack(); | |
} | |
tkref = (*muons)[i].isGlobalMuon() ? (*muons)[i].globalTrack() : (*muons)[i].muonBestTrack(); |
/// produce candidates | ||
void produce(edm::StreamID, edm::Event&, const edm::EventSetup&) const override; | ||
|
||
private: | ||
// L3/GLB Collection Label | ||
edm::InputTag m_L3CollectionLabel; | ||
edm::EDGetTokenT<reco::MuonCollection> muonToken_; | ||
bool m_displacedReco; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool m_displacedReco; | |
bool const m_displacedReco; |
The other two could also be made const
using the following in the ctor:
(i changed muonToken_
to m_muonToken
to follow the naming convention of the other data members)
: m_L3CollectionLabel(parameterSet.getParameter<InputTag>("InputObjects")), // standAlone Collection Label
m_muonToken(consumes(m_L3CollectionLabel)),
m_displacedReco(parameterSet.getParameter<bool>("DisplacedReconstruction")) {
LogTrace(category) << " constructor called";
produces<RecoChargedCandidateCollection>();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the name to the one you suggest and made const
the other two attributes.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29431
|
Pull request #37636 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2307cb/24078/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late comments from my side. Feel free to squash into 1 commit in the next update.
if (m_displacedReco) { | ||
tkref = (*muons)[i].isGlobalMuon() ? (*muons)[i].globalTrack() : (*muons)[i].muonBestTrack(); | ||
} else { | ||
tkref = ((*muons)[i].innerTrack().isNonnull()) ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tkref = ((*muons)[i].innerTrack().isNonnull()) ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack(); | |
tkref = (*muons)[i].innerTrack().isNonnull() ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack(); |
@@ -1,5 +1,6 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cfi
file can now be removed. I don't see it used anywhere, and it will now be created automatically via fillDescriptions
.
…muons Applied comments from PR review Removed cfi and small change
d109396
to
14733ac
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29435
|
Pull request #37636 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
The RelVals-INPUT error in the PR tests is unrelated to this PR, I believe. |
+hlt
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
merge |
PR description:
This PR implements a small change in the
L3MuonCandidateProducerFromMuons
module. A summary of this PR can be found on this slides.When this module was used with displaced muons a degradation in efficiency and resolution was observed. The reason was that this module was taking the innerTrack of the muon by default for momentum estimation. For displaced muons its better to take the globalTrack as shown in the attached slides (better efficiency and resolution).
We propose to add a flag to turn on the displaced reconstruction. This flag is set false by default to not interfere with the prompt reconstruction.
PR validation:
This PR passed the
scram b runtests
and code quality checks.