-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small fix to enable CSC unpacker in L1T DQM sequence #37634
small fix to enable CSC unpacker in L1T DQM sequence #37634
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37634/29420
|
A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d6f5b/24067/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
urgent |
@cms-sw/dqm-l2 We would like to include this into 12_4_0_pre3. Please review it at your earliest convenience, Thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a small fix for issue 37584.
The CSC shower DQM, enabled since PR 37544, takes muonCSCDigis as input, while it is not enabled in L1T DQM sequence by default.
Enable CSC unpacker here to avoid errors.
In discussion with L1T SW expert to see if this fix complies with CMSSW rules/conventions. A more appropriate fix will be made if needed.
PR validation:
The relevant sequence
l1tstage2_dqm_sourceclient-live_cfg.py
runs fine.Matrix test not performed as it is a very simple change.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A