fix the cms EDModule type of GenParticleMatchMerger

[mmusich]

PR description:

It appears that CollectionAdder

cmssw/CommonTools/UtilAlgos/interface/CollectionAdder.h

Line 17 in 837fd56

class CollectionAdder : public edm::global::EDProducer<> {

which is the underlying module type of

cmssw/PhysicsTools/HepMCCandAlgos/plugins/GenParticleMatchMerger.cc

Line 4 in 6d2f660

typedef CollectionAdder<reco::GenParticleMatch> GenParticleMatchMerger;

is an EDProducer, but it was declared in the configuration as an EDFilter:

cmssw/SimTracker/TrackAssociation/python/allTrackMCMatch_cfi.py

Line 3 in 837fd56

allTrackMCMatch = cms.EDFilter("GenParticleMatchMerger",

leading to runtime errors of the type:

----- Begin Fatal Exception 19-Apr-2022 00:54:18 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=GenParticleMatchMerger label='allTrackMCMatch'
Exception Message:
The base type in the python configuration is EDFilter, but the base type
for the module's C++ class is EDProducer. Please fix the configuration.
It must use the same base type as the C++ class.
----- End Fatal Exception -------------------------------------------------

this is trivially fixed here.
In addition in commit f68a4df, I take care of some other mismatched types in the configuration.
The parameter associator of MCTrackMatcher should be a cms.string and not a cms.InputTag:

cmssw/SimTracker/TrackAssociation/plugins/MCTrackMatcher.cc

Line 44 in 9583b99

: associator_(consumes<reco::TrackToTrackingParticleAssociator>(p.getParameter<string>("associator"))),

Finally in the same commit, the value of the variable associator in Tracker/TrackAssociation/python/trackMCMatch_cfi.py is corrected such that it is trackAssociatorByHits and not TrackAssociatorByHits

PR validation:

Private scripts.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A
cc: @tvami

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37613/29384

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• SimTracker/TrackAssociation (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mtosi, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @jhgoh, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd5955/24002/summary.html
COMMIT: ac0263e
CMSSW: CMSSW_12_4_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37613/24002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589913
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

hold

• more fixes are needed down the line.

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

unhold

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37613/29394

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37613 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd5955/24028/summary.html
COMMIT: f68a4df
CMSSW: CMSSW_12_4_X_2022-04-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37613/24028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.503 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589901
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1