-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L1-O2O] WriterProxyT changes to use ESGetToken #37600
Closed
panoskatsoulis
wants to merge
134
commits into
cms-sw:master
from
panoskatsoulis:l1o2o_WriterProxyT_migrationTo_ESGetToken
Closed
[L1-O2O] WriterProxyT changes to use ESGetToken #37600
panoskatsoulis
wants to merge
134
commits into
cms-sw:master
from
panoskatsoulis:l1o2o_WriterProxyT_migrationTo_ESGetToken
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make both ME1a and ME1b LCT (A/CLCT) sorted into ring 1.
…pre6 HLT menu migration to 12_3_0_pre6 template
…GTsForRun3 Update TSG tests and Relval Steps to use new run3_[hlt|data]_relval GTs
[12.3.X] Bugfix for Strips O2O
…Plots-12_3_X_backport Lumi-based status plots, backport to CMSSW_12_3_X
…_12_3_X [12_3_X] Modernize `DQM/BeamMonitor/plugins/TKStatus` plugin
…_12_3_X [12.3.X] Introduce alignment campaign-like unit test for `pede`
…-02-28-1100_mkFit_X [MkFit] Fix UBSAN error in (almost) empty events (backport of cms-sw#37146)
L1T ASAN heap-buffer-overflow fix resulting from PR cms-sw#36919
Run3-sim115XB Backport the bugfix in CaloSimHitStudy as in cms-sw#37246
…CMSSWVErsion [12_3_X] Add CMSSW version to StatisticsSenderService
…ting. Update tdc_HE to tdc_boundary name
cleanup headers and apply code checks Fix RecHits size conversion apply code format add single plugin to monitor rechits; delete files not needed code-format and buildfile cleaning cleanup header cleanup header
…pagation to several HLT filters
The "hltListPaths" script is updated to support FinalPaths, give the option to ignore paths by name (by means of regular expressions), and give the option to ignore paths that depend on the result of other paths in the same job. The "hltIntegrationTests" script is updated to ignore Paths that depend on the result of other Paths in the same job, as by construction those cannot be tested without other Paths.
[12_3_X] Make sure all dictionaries in CUDADataFormats are transient
…d123X Backport the refactoring of the PropagateToMuon class and add the propagating to some HLT filters
update of `hltIntegrationTests` and path of Run-3 Data file for TSG tests [`12_3_X`]
[123X] Change ALCALUMIPIXELSEXPRESS to ALCALumiPixelsCountsExpress in autoAlCa.py
cmsbuild
added
alca-pending
analysis-pending
code-checks-pending
core-pending
db-pending
dqm-pending
geometry-pending
heterogeneous-pending
hlt-pending
l1-pending
operations-pending
orp-pending
pdmv-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
labels
Apr 17, 2022
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37600/29365 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37600/29365/cms-checkout-topic.log |
wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alca-pending
analysis-pending
code-checks-rejected
core-pending
db-pending
dqm-pending
geometry-pending
heterogeneous-pending
hlt-pending
l1-pending
operations-pending
orp-pending
pdmv-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR implements
WriterProxy
fromCondTools/L1TriggerExt
to inherit fromedm::EDConsumerBase
as it's required for runningesConsumes()
to registerESGetToken
objects when is called by CondDBPayloadWriterPR validation:
This pkg is part of the L1 O2O and there is not any central wf to be tested
Tested Locally and from custom patch on machine
conddb-1
writing to sqlite file and Prep respectivelyThe local replica of the p5 script is commited together in this PR (
runL1-O2O-iov.sh
)if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport needed
PR to
master
is needed but there are conflicts atm