Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend eta range for jets seeding tau reco&ID #37520

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Apr 11, 2022

PR description:

This PR is to extend eta range for jets seeding tau reco&ID from |eta| of 2.5 to 2.7.
It was found that Phase-2 tracker allows to reconstruct and identify effectively taus up to |eta| of 2.5 instead of 2.3 recommended so far [1]. |Eta| of 2.5 is identical as for electrons which reconstruction also bases on combination of information in tracker and ECAL.
Therefore, we want to extend the eta range enabled for jets seeing tau reco to minimize edge effect when direction of the jet and reconstructed corresponding tau are different.

Expected changes: small increase of taus at |eta|~2.5.

[1] https://indico.cern.ch/event/1142990/#4-deeptau-developments-for-run sl. 8

PR validation:

Tested with10024.0 (TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37520/29236

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • RecoTauTag/RecoTau (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mbluj, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Apr 11, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08861d/23816/summary.html
COMMIT: 6db9d13
CMSSW: CMSSW_12_4_X_2022-04-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37520/23816/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2116 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 689
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3592327
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

  • reco changes reflect the changes introduced by the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

+1

@cmsbuild cmsbuild merged commit 06c3102 into cms-sw:master Apr 20, 2022
@mbluj mbluj deleted the CMSSW_12_4_X_extSeedEta branch March 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants