Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1T MuonShowers for HLT #37503

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Fix L1T MuonShowers for HLT
Change in uGT repack file fixes issue #37482

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of bug fix #37502

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • HLTrigger/HLTfilters (hlt)

@perrotta, @Martin-Grunewald, @cmsbuild, @missirol, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @silviodonato, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@Martin-Grunewald
Copy link
Contributor Author

backport of #37502

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8de6d/23760/summary.html
COMMIT: 80cadb3
CMSSW: CMSSW_12_3_X_2022-04-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37503/23760/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697351
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos, @davidlange6 please sign for operations

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

+1

@cmsbuild cmsbuild merged commit 47303c9 into cms-sw:CMSSW_12_3_X Apr 8, 2022
@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

Ok, by mistake I merged the 12_3_X version before the master one.
I don't expect problems with it, anyhow: let it as such, no need to revert while waiting for the master version being tested in the IBs (we can still revert just in case of unexpected issues there)

@missirol missirol deleted the FixL1TMuonShowerAccess branch April 30, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants