Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 12_3_X for CSC unpacking update PR#37279 #37479

Conversation

barvic
Copy link
Contributor

@barvic barvic commented Apr 6, 2022

PR description:

Backport to 12_3_X for CSC unpacking update PR #37279

if this PR is a backport please specify the original PR and why you need to backport that PR:

Would need to have those unpacking updates deployed at P5 soon as possible for proper unpacking of CSC ALCT/(O)TMB data with new versions of firmware with enabled Run3 features

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

A new Pull Request was created by @barvic (Victor Barashko) for CMSSW_12_3_X.

It involves the following packages:

  • EventFilter/CSCRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @ptcox this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2022

backport of #37279

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e31e5/23684/summary.html
COMMIT: 8640be8
CMSSW: CMSSW_12_3_X_2022-04-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37479/23684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 484
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696875
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2022

"Removing the +1 here: I did not notice that it still misses the reco signature"

  • Master version of this PR already merged since CMSSW_12_4_X_2022-04-06-1100

@barvic
Copy link
Contributor Author

barvic commented Apr 7, 2022

Dear @clacaputo, could you please review and sign this back-port, so @perrotta could proceed with merging this PR to 12_3_X and then it could be available for P5 deployment?

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2022

+1

@cmsbuild cmsbuild merged commit 017e8b6 into cms-sw:CMSSW_12_3_X Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants