minor changes to SiPixelLorentzAnglePCL modules [12.3.X]

[mmusich]

backport of #37455

PR description:

The goal of this PR is to introduce few minor improvements to the SiPixelLorentzAnglePCL modules:

• loosen the cluster size cut on BPix L2 from 4 to 3, as per presentation at AlCa/DB meeting Mar 28^th;
• zero the errors in several per sector monitor elements (to ease comparison using DQM GUI);
• avoid bounds checks in array access to speed-up computations;
• shorten per-sector bin names;
• reset ME h_drift_depth_adc_slice_ after computation is done;

PR validation:

Private tests to be completed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37455

cc:
@wweiphy

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from minor changes to SiPixelLorentzAnglePCL modules #37455

[francescobrivio]

@cmsbuild please test

[francescobrivio]

urgent

• targeting 12_3_0 (the SiPixelLorentzAnglePCL modules will be run in tier0)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d5c79/23649/summary.html
COMMIT: a48582c
CMSSW: CMSSW_12_3_X_2022-04-04-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37459/23649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 47
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697312
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• runs fine in master IB CMSSW_12_4_X_2022-04-05-1100

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of minor changes to SiPixelLorentzAnglePCL modules #37455