Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 123X] pT dependent ROI producers for Muon HLT #37458

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

khaosmos93
Copy link
Contributor

Backport of #37286. The backport is needed for the first Run 3 data taking.
No difference in codes w.r.t. the original PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2022

A new Pull Request was created by @khaosmos93 (Minseok Oh) for CMSSW_12_3_X.

It involves the following packages:

  • RecoMuon/GlobalTrackingTools (reconstruction)
  • RecoTracker/TkTrackingRegions (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@sscruz, @trocino, @Fedespring, @CeliaFernandez, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @HuguesBrun, @ebrondol, @jhgoh, @amagitte, @gpetruc, @mmusich, @mtosi, @dgulhan, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Apr 5, 2022

urgent

Requested by TSG for 12_3_0, see #37286 (comment).

@missirol
Copy link
Contributor

missirol commented Apr 5, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94401d/23647/summary.html
COMMIT: 03057b3
CMSSW: CMSSW_12_3_X_2022-04-04-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37458/23647/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697357
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2022

backport of #37286

@qliphy
Copy link
Contributor

qliphy commented Apr 7, 2022

+1

@cmsbuild cmsbuild merged commit 5b83179 into cms-sw:CMSSW_12_3_X Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants