-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_3_X] Fix xml tag in PPS strips mapping #37450
Conversation
A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_3_X. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bugfix |
backport of #37449 |
test parameters:
|
@cmsbuild please test |
@ChrisMisan thanks for this backport! Could you please add "[12_3_X]" in the title? And please mention in the title that these are the PPS strips, not the SiStrips :) (also for the master PR) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eadfe1/23630/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
PR adds a missing closing tag to the strips xml mapping.
PR validation:
relvals 136.793, 136.874
if this PR is a backport please specify the original PR and why you need to backport that PR:
original PR #37449