Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_2_X] Set concurrent lumis/IOVs in ConfigBuilder if their value is different from default regardless of the number of threads #37445

Merged
merged 2 commits into from
Apr 4, 2022
Merged

[12_2_X] Set concurrent lumis/IOVs in ConfigBuilder if their value is different from default regardless of the number of threads #37445

merged 2 commits into from
Apr 4, 2022

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Apr 2, 2022

PR description:

Backport of #37417.

PR validation:

The first commit is the original development and was tested with the case described in #37385. No further testing.

makortel added 2 commits March 28, 2022 23:44
@makortel
Set concurrent lumis/IOVs if their value is different from default re…
330e636 
…gardless of the number of threads

It can happen that the job configuration is generated with cmsDriver
without specifying the number of threads (i.e. that is 1), and ends up
being used with number of threads being overridden. If the number of
concurrent lumis/IOVs is set different from the default in such case,
that setting would be lost.
@makortel
Remove setting of DQMStore.assertLegacySafe as unnecessary
fc522df 
This parameter was set to False already in
cms-sw#34366
@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Apr 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_12_2_X.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Apr 2, 2022

@cmsbuild, please test

@makortel makortel mentioned this pull request Apr 2, 2022
Closed
3 tasks
@makortel makortel mentioned this pull request Apr 2, 2022
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-638a87/23624/summary.html
COMMIT: fc522df
CMSSW: CMSSW_12_2_X_2022-04-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37445/23624/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Apr 4, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7aaa4a4 into cms-sw:CMSSW_12_2_X Apr 4, 2022
@makortel makortel deleted the concurrentLumiConfigBuilder_12_2_x branch April 4, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed operations-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_2_X
Development

Successfully merging this pull request may close these issues.
3 participants
@makortel @cmsbuild @qliphy