Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Added muon-tau-jet OvRm Filter #37426

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

jaimeleonh
Copy link
Contributor

PR description:

Backport of #37424

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2022

A new Pull Request was created by @jaimeleonh (Jaime Len Holgado) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Mar 31, 2022

backport of #37424

This PR adds a producer for HLT which is not presently used in any wfs nor HLT menus. It is added in case the producer turns out to be needed for HLT menus running in 12_3_X at the start of Run 3.

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8849b8/23578/summary.html
COMMIT: f73f854
CMSSW: CMSSW_12_3_X_2022-03-31-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37426/23578/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250202.18250202.18_TTbar_13UP18+TTbar_13UP18INPUT+DIGIPRMXUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18INPUT+DIGIPRMXUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697333
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Apr 1, 2022

+hlt

@jaimeleonh , please add "[12_3_X]" (or similar) to the title of this backport PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jaimeleonh jaimeleonh changed the title Added muon-tau-jet OvRm Filter [12_3_X] Added muon-tau-jet OvRm Filter Apr 1, 2022
@perrotta
Copy link
Contributor

perrotta commented Apr 1, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Apr 1, 2022

merge

@cmsbuild cmsbuild merged commit 93cac63 into cms-sw:CMSSW_12_3_X Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants