-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable concurrent IOVs by default in ConfigBuilder #37419
Conversation
I was supposed to do this at the same time as cms-sw#35302 that followed cms-sw#34231 and the conclusion in cms-sw#33436
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37419/29096
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable threading |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06cef5/23569/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
While investigating #37385 / #37417 I noticed the default value in ConfigBuilder for the number of concurrent IOVs was still 1. I was supposed to change this to 0 at the time as #35302 that followed the default value logic addition to
cmsRun
directly in #34231. This PR sets the default value to 0, which means that the number of concurrent IOVs is set to be the same as the number of concurrent lumis.For future reference, the main concern at the time was the memory usage of the additional per-lumi EventSetup products, which was concluded to be small in #33436.
PR validation:
Limited matrix (plus some more) runs multithreaded