[12_3_X] Fix tag names in DQM Fake BeamSpot clients

[francescobrivio]

PR description:

Backport of #37376
Following the discussion with BeamSpot/DB/HLT/DAQ experts, in order to stress test the system and prove that the coral patch works we need to re-deploy in production the fake BeamSpot DQM clients that create fake (TRandom) BeamSpot values and upload them to the DB. This will not affect data quality in any way since the fake clients will be deployed only during cosmics, when the beamspot is not really used/useful in any case.

In order not to pollute the production tags with "fake" BeamSpot payloads, this PR changes the name of the output tag to which the payloads are uploaded to. The tag name changes are:

• BeamSpotOnlineLegacy --> BeamSpotOnlineFakeLegacy
• BeamSpotOnlineHLT --> BeamSpotOnlineFakeHLT

PR validation:

Code compiles.

Backport:

Backport of #37376

[francescobrivio]

backport of #37376

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix tag names in DQM Fake BeamSpot clients #37376

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07f72d/23450/summary.html
COMMIT: d77c965
CMSSW: CMSSW_12_3_X_2022-03-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37377/23450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695161
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695137
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Backport Tested successfully in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[jfernan2]

-1
A new test produced crashes at P5

[francescobrivio]

-1
A new test produced crashes at P5

I just want to point out that the failure is not due to the changes in this PR. We are investigating what is causing them.

[jfernan2]

I agree @francescobrivio
Do you prefer to merge this PR (and its master version) given that the 12_2_X backport has been alreday merged, and fix the crashes in a different PR? Honestly, I have no preference, I just removed my sign since I thought you wanted to add the solution here instead of in a new PR

[francescobrivio]

I agree @francescobrivio Do you prefer to merge this PR (and its master version) given that the 12_2_X backport has been alreday merged, and fix the crashes in a different PR? Honestly, I have no preference, I just removed my sign since I thought you wanted to add the solution here instead of in a new PR

I think only the master PR has been merged (which is fine since the fake BS clients are not really used anywhere else), while the 12_2_X backport is still open.
Personally I dont' think this issue will require fixing the code, but rather doing something on the DB side (investigation ongoing).
So I'd prefer to keep the 12_2 open until we can try a new playback. This PR for 12_3 can instead be merged as it is, if further changes will be needed I will open new PRs.
Do you agree?

[jfernan2]

Yes, you are right, only master was merged. Sorry
Fine for me
Thanks

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Merging, due to [12_3_X] Fix tag names in DQM Fake BeamSpot clients #37377 (comment) and [12_3_X] Fix tag names in DQM Fake BeamSpot clients #37377 (comment)