-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex124E Try to remove compilation warnings in RecoParticleFlow/PFTracking #37369
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37369/29024
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37369/29025
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efe439/23436/summary.html Comparison SummarySummary:
|
@@ -4,7 +4,6 @@ | |||
// standard EDAnalyser include files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please modify
#ifndef PFCheckHitPattern_H | |
#define PFCheckHitPattern_H |
to
#ifndef RecoParticleFlow_PFTracking_PFCheckHitPattern_H
#define RecoParticleFlow_PFTracking_PFCheckHitPattern_H
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37369/29055
|
Pull request #37369 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efe439/23489/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Try to remove compilation warnings in RecoParticleFlow/PFTracking
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special