Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 #37346

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Mar 25, 2022

PR description:

Backport of #37345.
This PR builds on top of #37344 by adding a relval wf to the matrix in order to test the new ECAL AlCaPhiSym workflow for Run3. It produces nano as output and it will be eventually tested in a tier0 replay (we still need to sort out some details).

PR validation:

Tested with:
runTheMatrix.py -l 139.005 --ibeos -j8 -t8

Backport:

Backport of #37345.

FYI @simonepigazzini @rappoccio @cms-sw/alca-l2

@francescobrivio francescobrivio changed the title Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 [12_3_X] Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 Mar 25, 2022
@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Mar 25, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Mar 25, 2022

backport of #37345

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows=139.005

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@tvami
Copy link
Contributor

tvami commented Mar 25, 2022

@francescobrivio I think we need to attach #37344 (comment) to this

@tvami
Copy link
Contributor

tvami commented Mar 25, 2022

test parameters:

@tvami
Copy link
Contributor

tvami commented Mar 25, 2022

@cmsbuild , please abort

@tvami
Copy link
Contributor

tvami commented Mar 25, 2022

@cmsbuild , please test

@francescobrivio
Copy link
Contributor Author

@francescobrivio I think we need to attach #37344 (comment) to this

you are aboslutely right, I had it in mind and then I forgot to add it to the test parameters! Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7515/23393/summary.html
COMMIT: f44a566
CMSSW: CMSSW_12_3_X_2022-03-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37346/23393/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe7515/139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #37346 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe7515/23410/summary.html
COMMIT: c9b81ae
CMSSW: CMSSW_12_3_X_2022-03-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37346/23410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe7515/139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@jordan-martins
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 29, 2022

+1

@cmsbuild cmsbuild merged commit 2e82f40 into cms-sw:CMSSW_12_3_X Mar 29, 2022
@francescobrivio francescobrivio deleted the alca-alcaphysim_12_3_X branch April 6, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants