Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X + Update of L1T menu in TSG GTs [12_3_X] #37339

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

missirol
Copy link
Contributor

backport of #37338

PR description:

Development of HLT menus for CMSSW_12_3_X + Update of L1T menu in TSG GTs to L1Menu_Collisions2022_v0_1_8_xml.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2245: introduction of Dataset Paths (and FinalPaths).

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37338

Development of HLT menus for Run-3 startup.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d83d1b/23364/summary.html
COMMIT: 126c6a6
CMSSW: CMSSW_12_3_X_2022-03-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37339/23364/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695155
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.096 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.516 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@missirol
Copy link
Contributor Author

The original PR (#37338) tested okay in IBs, including the "HLT-Validation" tests (see CMSSW_12_4_X_2022-03-25-1100).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2b53836 into cms-sw:CMSSW_12_3_X Mar 27, 2022
@missirol missirol deleted the HLTdevelopment123X branch March 27, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants