ME1a CLCT will use ME1a SimHit Strip and be saved into ME1a plot

[sifuluo]

PR description:

Trying to fix the comparison failures mentioned: #37268

PR validation:

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28959

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28959/cms-checkout-topic.log

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28960

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28960/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28960/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28963

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @sifuluo (Sifu Luo) for master.

It involves the following packages:

• Validation/MuonCSCDigis (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

Thank you @sifuluo!

As additional (unrelated but welcome) cleaning, could you also please:

• Remove from CSCStubResolutionValidation.h the following unused class members:
  • inputTag_
  • simTrackMinPt_ , simTrackMinEta_ , imTrackMaxEta_
• Replace in CSCStubResolutionValidation.h the line

   ~CSCStubResolutionValidation() override;

with

   ~CSCStubResolutionValidation() override = default;

and remove the doing-nothing destructor from CSCStubResolutionValidation.cc

[sifuluo]

Either/both the changes to the destructor will fail the compiling.
So I only removed the unused class members

[perrotta]

please test

[sifuluo]

@perrotta the test didn't seem to be started

[perrotta]

Indeed: bot seems stuck
@smuzaffar do you have any hint?

[smuzaffar]

humm, strange , I am am checking

[smuzaffar]

please test

[smuzaffar]

code-checks

[smuzaffar]

@perrotta , looks like github again has issues today ( https://www.githubstatus.com/ ) . That is why bot was not able to add the code-checks status. lets wait for github to come to normal state

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37319/28966

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #37319 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

[smuzaffar]

looks like github is coming back, bot has reacted and started the test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d51e85/23328/summary.html
COMMIT: d2190cc
CMSSW: CMSSW_12_4_X_2022-03-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37319/23328/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @rovere Clue3D absolute metric #37172

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d51e85/23328/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d51e85/23328/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d51e85/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 51310
• DQMHistoTests: Total nulls: 67
• DQMHistoTests: Total successes: 3644251
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[jfernan2]

@sifuluo please create backports of this PR to propagate the fix
Thanks

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1