-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated path to EDM file for TSG tests on Run-3 Data [12_2_X
]
#37292
updated path to EDM file for TSG tests on Run-3 Data [12_2_X
]
#37292
Conversation
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_2_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix This is meant to fix the failure of the "HLT-Validation" tests in recent 12_2_X IBs, e.g. |
+hlt Signing in advance. This file does not get tested in PR tests, and the signature should anyway trigger the tests (I want to check if it does). |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e542cb/23257/summary.html Comparison SummarySummary:
|
This still does not work for me, presumably because I now need grid access to run this, as the file is not at cern. This may be a performance problem, and so far I did not need to set up grid access to run the TSG tests. Unfortunatley, running |
Should we then simply keep this EDM file in the TSG area on EOS? |
Yes, that would be better indeed! Sorry for going back to your original. |
Then actually we should update the addOnHLT tests to use the eos location as well. |
Okay, will do (in both/all PRs). |
3b85b7a
to
bb7cf55
Compare
bb7cf55
to
eb7402d
Compare
Pull request #37292 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test
I had forgotten the update of the file-path in the |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e542cb/23296/summary.html Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #37283
PR description:
Partial backport of #37283. With respect to the original PR, this backport includes only the fix to the path of the EDM file used for TSG tests on Run-3 Data.
PR validation:
Relies on the tests done for the original PR.
If this PR is a backport, please specify the original PR and why you need to backport that PR:
#37283
This partial backport is needed to fix a problem with file access in the "HLT-Validation" tests of the IBs.