-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic improvement in printout of Payload Inspector plots for DropBoxMetaData #37288
Conversation
attn: @mmusich |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37288/28919
|
A new Pull Request was created by @tlampen (Tapio Lampén) for master. It involves the following packages:
@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@tlampen based on the screenshots you attached: I see that in the first one (that should be the new one) there is a new line before "inputTag" in the "PREP" section, but not in the "PROD" section, is this expected? |
Good catch. I'll fix this. Thanks! |
706d87f
to
b472fa8
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37288/28920
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9046a/23255/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As continuation to PR #37011, improve legibility of printouts by adding a newline in front of new tag ("inputTag").
PR validation:
The correct behaviour is illustrated with the attached plots produced with a modified version of the script test/test_DropBoxMetadata_PayloadInspector.sh (plots with and without these modifications).
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A