-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce generalized abstraction for Strip Payload Inspector #37265
Introduce generalized abstraction for Strip Payload Inspector #37265
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28892
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28894
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadc83/23195/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28937
|
@cmsbuild please test |
Ciao Marco. |
Ciao Andrea, |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadc83/23288/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: @slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The purpose of this PR is to introduce a generalized abstraction for Strip Payload inspector
SiStripCondObjectRepresent
and use it to make detailed comparison and correlation plots for the Strip payload inspector.PR validation:
Relies on augmented unit tests and extended private validation.
Example of plots obtainable with the new additions.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A