-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use git init instead of git cms-init which creates a sparse checkout area #37260
use git init instead of git cms-init which creates a sparse checkout area #37260
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37260/28883
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Ah, that was the mistake. Thanks! |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccc2e0/23193/summary.html Comparison SummarySummary:
|
please test |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccc2e0/23199/summary.html Comparison SummarySummary:
|
+1 |
Unit test TestFWCoreSkeletons is using
git cms-init
which creates a sparse checkout area and causes the test to fail. Usinggit init
should fix this issue.Although unit tests fails for IBs ( https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_4_X_2022-03-16-2300/unitTestLogs/FWCore/Skeletons#/ ) but it is not visible via the IB dashboard. This is because the unit tests is internally creating and compiling packages which confuses ourunit test log parser ( https://github.com/cms-sw/cms-bot/blob/master/checkTestLog.py#L107-L108 ) which search for messages like
cms-sw/cmsdist#7698 should fix this parsing issue