[12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242

sroychow · 2022-03-14T19:36:01Z

PR description:

Backport of #37193 and #37174.

PR validation:

Code compiles.

cmsbuild · 2022-03-14T19:36:19Z

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for CMSSW_12_3_X.

It involves the following packages:

DQM/SiPixelPhase1Heterogeneous (dqm)
RecoLocalTracker/SiPixelRecHits (reconstruction)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @slava77, @jpata, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@ferencek, @hdelanno, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @gpetruc, @OzAmram, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @dkotlins, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from DQM modules to monitor Pixel RecHits for heterogenous workflows #37174

sroychow · 2022-03-14T19:42:53Z

test parameters

workflows = 11634.501, 11634.502, 11634.505

sroychow · 2022-03-14T19:43:02Z

enable gpu

sroychow · 2022-03-14T19:43:14Z

@cmsbuild please test

cmsbuild · 2022-03-14T23:47:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fe1ba/23110/summary.html
COMMIT: be8bdb9
CMSSW: CMSSW_12_3_X_2022-03-14-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37242/23110/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19811
DQMHistoTests: Total failures: 1928
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 17883
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8031.437 KiB( 3 files compared)
DQMHistoSizes: changed ( 11634.506 ): 8031.437 KiB SiPixelHeterogeneous/PixelRecHitsSoA
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695161
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695122
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

qliphy · 2022-03-15T07:36:30Z

backport of #37193
backport of #37174

perrotta · 2022-03-15T07:43:18Z

backport of #37174
(To allow bot considering the one which is not yer merged: the status will switch to "backport-ok" as soon as also #37174 is merged in master)

jpata · 2022-03-15T16:06:45Z

+reconstruction

for the backport of Removing assert to address the issue #35668 #37193, it's exact and there are no changes

jfernan2 · 2022-03-15T16:54:12Z

+1

cmsbuild · 2022-03-15T16:54:35Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

sroychow · 2022-03-22T09:10:34Z

@cmsbuild please test

cmsbuild · 2022-03-22T19:58:16Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fe1ba/23287/summary.html
COMMIT: 9d5168d
CMSSW: CMSSW_12_3_X_2022-03-22-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37242/23287/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19811
DQMHistoTests: Total failures: 1649
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 18162
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8031.437 KiB( 3 files compared)
DQMHistoSizes: changed ( 11634.506 ): 8031.437 KiB SiPixelHeterogeneous/PixelRecHitsSoA
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-03-23T08:25:30Z

Undefined workflow: 11634.502

perrotta · 2022-03-25T18:43:43Z

test parameters:

perrotta · 2022-03-25T18:45:24Z

test parameters:

workflows_gpu = 11634.501, 11634.502, 11634.505

perrotta · 2022-03-25T18:46:06Z

please test

cmsbuild · 2022-03-25T22:30:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fe1ba/23402/summary.html
COMMIT: 9d5168d
CMSSW: CMSSW_12_3_X_2022-03-25-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37242/23402/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19811
DQMHistoTests: Total failures: 2499
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 17312
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8031.437 KiB( 3 files compared)
DQMHistoSizes: changed ( 11634.506 ): 8031.437 KiB SiPixelHeterogeneous/PixelRecHitsSoA
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695161
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695128
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-03-26T15:16:03Z

+1

jpata · 2022-03-28T11:45:27Z

+reconstruction

no relevant changes since [12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242 (comment)

cmsbuild · 2022-03-28T11:49:00Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-03-28T13:08:20Z

+1

cmsbuild added this to the CMSSW_12_3_X milestone Mar 14, 2022

cmsbuild added dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 14, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2022

cmsbuild added the backport-ok label Mar 15, 2022

cmsbuild added backport and removed backport-ok labels Mar 15, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 15, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 15, 2022

mmusich mentioned this pull request Mar 17, 2022

DQM modules to monitor Pixel RecHits for heterogenous workflows #37174

Merged

cmsbuild added tests-started backport-ok and removed tests-pending backport labels Mar 22, 2022

cmsbuild added tests-rejected and removed tests-started labels Mar 22, 2022

cmsbuild added tests-started and removed tests-rejected labels Mar 25, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 25, 2022

cmsbuild added dqm-approved and removed dqm-pending labels Mar 26, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Mar 28, 2022

cmsbuild added orp-approved and removed orp-pending labels Mar 28, 2022

cmsbuild merged commit d35b672 into cms-sw:CMSSW_12_3_X Mar 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242

[12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242

sroychow commented Mar 14, 2022

cmsbuild commented Mar 14, 2022 •

edited

Loading

sroychow commented Mar 14, 2022 •

edited

Loading

sroychow commented Mar 14, 2022

sroychow commented Mar 14, 2022

cmsbuild commented Mar 14, 2022

qliphy commented Mar 15, 2022 •

edited

Loading

perrotta commented Mar 15, 2022

jpata commented Mar 15, 2022

jfernan2 commented Mar 15, 2022

cmsbuild commented Mar 15, 2022

sroychow commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

jfernan2 commented Mar 23, 2022

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

jfernan2 commented Mar 26, 2022

jpata commented Mar 28, 2022

cmsbuild commented Mar 28, 2022

perrotta commented Mar 28, 2022

[12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242

[12.3.X] DQM modules to monitor Pixel RecHits & remove assert in SiPixelRecHitSoAFromLegacy plugin #37242

Conversation

sroychow commented Mar 14, 2022

PR description:

PR validation:

cmsbuild commented Mar 14, 2022 • edited Loading

sroychow commented Mar 14, 2022 • edited Loading

sroychow commented Mar 14, 2022

sroychow commented Mar 14, 2022

cmsbuild commented Mar 14, 2022

GPU Comparison Summary

Comparison Summary

qliphy commented Mar 15, 2022 • edited Loading

perrotta commented Mar 15, 2022

jpata commented Mar 15, 2022

jfernan2 commented Mar 15, 2022

cmsbuild commented Mar 15, 2022

sroychow commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

RelVals

GPU Comparison Summary

jfernan2 commented Mar 23, 2022

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

GPU Comparison Summary

Comparison Summary

jfernan2 commented Mar 26, 2022

jpata commented Mar 28, 2022

cmsbuild commented Mar 28, 2022

perrotta commented Mar 28, 2022

cmsbuild commented Mar 14, 2022 •

edited

Loading

sroychow commented Mar 14, 2022 •

edited

Loading

qliphy commented Mar 15, 2022 •

edited

Loading