Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.2.X] Introduce alignment campaign-like unit test for pede #37212

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 11, 2022

backport of #37211

PR description:

As discussed here cms-sw/cmsdist#7660 (comment) introduce a pede execution based off a real (small-scale) MC alignment campaign (cosmics-only). The needed input files to steer the execution are at: /store/group/alca_global/tkal_millepede_tests/

PR validation:

run scram b runtests_testPedeCampaign.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37211

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 11, 2022

@cmsbuild, please test

@mmusich mmusich changed the title [DO NOT MERGE] introduce alignment campaing-like unit test for pede [DO NOT MERGE] introduce alignment campaign-like unit test for pede Mar 11, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c93879/23047/summary.html
COMMIT: ad94dc4
CMSSW: CMSSW_12_2_X_2022-03-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37212/23047/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich force-pushed the addMillePedeTestingSetup_12_2_X branch from ad94dc4 to 87228db Compare March 13, 2022 19:26
@cmsbuild
Copy link
Contributor

Pull request #37212 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@mmusich mmusich changed the title [DO NOT MERGE] introduce alignment campaign-like unit test for pede [12.2.X] Introduce alignment campaign-like unit test for pede Mar 13, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Mar 13, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c93879/23075/summary.html
COMMIT: 87228db
CMSSW: CMSSW_12_2_X_2022-03-13-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37212/23075/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 13, 2022

Wouldnt we need the backport of cms-sw/cmsdist#7685 in 12_2_X as well?

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

Wouldnt we need the backport of cms-sw/cmsdist#7685 in 12_2_X as well?

No, the unit test runs, meaning that the pede version used in 12_2_X is fine.

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2022

what's the plan for inclusion of this PR?

@qliphy
Copy link
Contributor

qliphy commented Mar 16, 2022

+1

@cmsbuild cmsbuild merged commit 44079ec into cms-sw:CMSSW_12_2_X Mar 16, 2022
@mmusich mmusich deleted the addMillePedeTestingSetup_12_2_X branch March 16, 2022 06:17
@perrotta
Copy link
Contributor

@mmusich , since the merging of this PR in 12_2 we are getting in the IB and PR tests the following error in the testCalibrationTkAlCaRecoProducers unit test

----- Begin Fatal Exception 25-Mar-2022 05:18:35 CET-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module AlignmentProducerAsAnalyzer/'SiPixelAliPedeAlignmentProducer'
Exception Message:
@SUB=MillePedeFileReader::getStringFromHLS
Found an alignable structure not possible to map in the default AlignPCLThresholds partitions
----- End Fatal Exception -------------------------------------------------

I can't understand how it could be related, But the fact that MillePede is involved, and the time sequence with the merging of this PR makes me suspect it can have some correlation with it.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 25, 2022

@perrotta it is not related. I think a possible fix is at: cms-sw/cmsdist#7718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants