-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.2.X] Introduce alignment campaign-like unit test for pede
#37212
[12.2.X] Introduce alignment campaign-like unit test for pede
#37212
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
pede
pede
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c93879/23047/summary.html Comparison SummarySummary:
|
ad94dc4
to
87228db
Compare
pede
pede
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c93879/23075/summary.html Comparison SummarySummary:
|
Wouldnt we need the backport of cms-sw/cmsdist#7685 in 12_2_X as well? |
No, the unit test runs, meaning that the |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
what's the plan for inclusion of this PR? |
+1 |
@mmusich , since the merging of this PR in 12_2 we are getting in the IB and PR tests the following error in the testCalibrationTkAlCaRecoProducers unit test
I can't understand how it could be related, But the fact that MillePede is involved, and the time sequence with the merging of this PR makes me suspect it can have some correlation with it. |
@perrotta it is not related. I think a possible fix is at: cms-sw/cmsdist#7718. |
backport of #37211
PR description:
As discussed here cms-sw/cmsdist#7660 (comment) introduce a pede execution based off a real (small-scale) MC alignment campaign (cosmics-only). The needed input files to steer the execution are at:
/store/group/alca_global/tkal_millepede_tests/
PR validation:
run
scram b runtests_testPedeCampaign
.if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #37211