Tighten check for the number of weights in GenWeightValidation

[perrotta]

PR description:

Following a couple of issues reported after the merging of #36994:

• Non reproducibility of DQM histos filled in GenWeightValidation, which suggests some uninitialized or wrongly defined input value, see Add GEN/LHE weight validation subdirectories for GEN Relval #36994 (review) and following discussion in the thread
• out-of-bounds memory read coming from GenWeightValidation::analyze, as reported by ASAN, see Add GEN/LHE weight validation subdirectories for GEN Relval #36994 (comment)

@SanghyunKo suggested in #36994 (comment) a quite reasonable fix for them.

To speed up the integration in view of the 12_3_0pre6 deadline, I implement here the fix of @SanghyunKo, while waiting for some possible further feedback

Of course, if @SanghyunKo or anyone else finds a more appropriate solution, this PR can be closed and we can move to the new one.

PR validation:

• It builds
• The fix is quite logical, and needed in any case

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37185/28760

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• Validation/EventGenerator (dqm, generators)

@SiewYan, @mkirsano, @emanueleusai, @ahmad3213, @cmsbuild, @GurpreetSinghChahal, @jfernan2, @Saptaparna, @alberto-sanchez, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[SanghyunKo]

Thank you very much @perrotta, it looks good to me

[perrotta]

Thank you very much @perrotta, it looks good to me

Thank you to you @SanghyunKo : it was your suggestion in fact!

[perrotta]

type bugfix

[perrotta]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daeffd/22982/summary.html
COMMIT: fffff2f
CMSSW: CMSSW_12_3_X_2022-03-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37185/22982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3703700
• DQMHistoTests: Total failures: 58
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3703619
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 0 log files, 0 edm output root files, 49 DQM output files

[jfernan2]

Plots now get null entries while before they had entries
https://tinyurl.com/ybtfe4yc
It does not make much sense to save an empty histogram unless this is due to the type pf generator used in the WF for these Jenkins Tests

[jfernan2]

+1

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[perrotta]

Random differences in the generator weights have disappeared now, after the merging in the IB of this PR, see for example the results of the tests in 37161