Adding optionality for MTD timing in PFTICLProducer

[trtomei]

PR description:

We are facing a showstopper on porting the HLT Phase 2 Menu to CMSSW_12_3_0: for some reason, in our menu the link between MTD timing enabled tracks and PFCandidates is broken, and we are having difficulties in debugging it.

In view of the imminent closing of the prereleases, we would propose a blunt, but efficient alternative: adding a toggle to PFTICLProducer to use the MTD timing. Of course, by default it is set to true, but for the HLT menu it would temporarily be set to false.

As a bonus, it would cleanly allow to separate studies with timing from MTD vs timing from HGCAL, in the context of the HLT menu evolution.

PR validation:

Did the full tests:

cmsrel CMSSW_12_3_DEVEL_X_2022-03-06-2300
cd CMSSW_12_3_DEVEL_X_2022-03-06-2300/src
git cms-init
git merge trtomei/devel_trtomei_TICL-MTD-optional
scram b distclean 
git cms-checkdeps -a -A
scram b -j 8
scram b runtests

and

runTheMatrix.py -l limited -i all --ibeos

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37158/28711

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @trtomei (Thiago Tomei) for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)

@clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61c5c1/22896/summary.html
COMMIT: 6ded0b8
CMSSW: CMSSW_12_3_X_2022-03-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37158/22896/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3987741
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3987705
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

+upgrade

• Technical PR no change expected, no change seen. Differences in tests only from MessageLogger and TimerService.
• Even taking in account that this seems not urgent ( see Porting HLT Phase 2 simplified menu to 12_4_X #37162 (comment)) this simply adds a useful safety switch that can be turned on in order to have the Phase-2 HLT menu running smoothly at anytime.

[AdrianoDee]

@trtomei about this:

We are facing a showstopper on porting the HLT Phase 2 Menu to CMSSW_12_3_0: for some reason, in our menu the link between MTD timing enabled tracks and PFCandidates is broken, and we are having difficulties in debugging it.

shall we open an issue? To have it documented and experts participating to the discussion.

[trtomei]

Yes, I will open an issue as soon as soon as I have a simple reproducible recipe!

[clacaputo]

+reconstruction

• technical PR
• no reco changes expected or observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37158/28747

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #37158 was updated. @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please check and sign again.

[AdrianoDee]

Please test

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61c5c1/22952/summary.html
COMMIT: 5f491f0
CMSSW: CMSSW_12_3_X_2022-03-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37158/22952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 11 failed jobs
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3985573
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3985548
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 0 log files, 0 edm output root files, 49 DQM output files

[clacaputo]

+reconstruction

• re-sign Adding optionality for MTD timing in PFTICLProducer #37158 (comment)

[srimanob]

+Upgrade

Re-sign follows @AdrianoDee

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

Do we still a chance to integrate this to 12_3_0_pre6? If not, we will ask for the backport as it needs for Phase-2 HLT MC production with 12_3.

[perrotta]

+1