Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Add error message for undefined solid #37112

Merged
merged 1 commit into from
Mar 2, 2022
Merged

[DD4hep] Add error message for undefined solid #37112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,13 @@ static void convert_boolean(cms::DDParsingContext* context, xml_h element) {
Converter<DDLTransform3D>(context->description, context, &trafo)(element);
ns.context()->unresolvedShapes.emplace(nam,
DDParsingContext::BooleanShape<TYPE>(solidName[0], solidName[1], trafo));
if (solids[0].isValid() == false) {
printout(ERROR, "DD4CMS", "++ Solid not defined yet: %s", solidName[0].c_str());
}
if (solids[1].isValid() == false) {
printout(ERROR, "DD4CMS", "++ Solid not defined yet: %s", solidName[1].c_str());
}
printout(ERROR, "DD4CMS", "++ Re-order XML files to prevent references to undefined solids");
}
if (!boolean.isValid()) {
// Delay processing the shape
Expand Down