-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix era to be compliant with underlying D91 geometry #36931
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36931/28265
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36931/28266
|
Pull request #36931 was updated. @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin can you please check and sign again. |
test parameters:
|
@cmsbuild, please test |
type bug-fix |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10ed27/22351/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade PR to fix the era of D91, and add missing doc. |
+pdmv |
@cms-sw/geometry-l2 is there anything that prevents you signing this bug fix? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Addresses comment at #36660 (comment), in order to comply with the description of the geometry at:
cmssw/Configuration/Geometry/python/dict2026Geometry.py
Line 1750 in 09bb0b7
PR validation:
none
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A