-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more module transitions to MessageLogger #36801
Add more module transitions to MessageLogger #36801
Conversation
Added write run, write lumi and calling ES modules. This should fix some unit test failures.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36801/27949
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Fixes also #33224 |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
The trace log for the crash is identical to the one in the IB for a different workflow: |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
merge |
PR description:
Added write run, write lumi and calling ES modules.
This should fix some unit test failures.
PR validation:
Code compiles. Framework unit tests all pass.
fixes #36522