Add hgcalv16 modifier and corresponding era

[srimanob]

PR description:

This PR is to add a new modifier for HGCAL V16, and the corresponding era. Currently, HGCal V16 (C17) is used in D86 and D88. It needs new RecHits calibration, introduced in #36728. We need to split the modifier/era of D86 and D88 from C11, in order to keep D77 (default now) working as before.

PR validation:

This PR itself should do nothing. To see the effect of new RecHit calibration, it should be triggerred the test with #36728

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backporting.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36753/27866

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660, Remove Event Interpretation (EI) from relval steps #36465, ECAL Phase 2 Development WF 28234.61 fix #36748, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/Eras (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)

@perrotta, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

I am not this line that we need to keep V10,V11 and V12 or not. Will look into it.

[srimanob]

@kpedro88 Do you have an idea what is the result of this era line? I think it does not change anything at the moment. Thanks in advance.

[kpedro88]

@srimanob indeed, right now it is just printed as a recommendation when a user runs the geometry script. The actual modifiers for a workflow have to be implemented manually.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36753/27867

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660, Remove Event Interpretation (EI) from relval steps #36465, ECAL Phase 2 Development WF 28234.61 fix #36748, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

[cmsbuild]

Pull request #36753 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c9688/21818/summary.html
COMMIT: 1b09a9d
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36753/21818/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3464832
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[srimanob]

As described, no change is expected from this PR itself. The test with HGCal V16 rechit calibration is done in #36728 (comment)

[srimanob]

+Upgrade

The failure in PR test doest not relate to this PR. PR test alone shows no change as expected. Testing with #36728 shows expected behaviour, #36728 (comment)

[cvuosalo]

+1

[srimanob]

Kindly ping @cms-sw/pdmv-l2

[kskovpen]

+1

[perrotta]

+operations

• Successfully tested together with HGCAL RecHits Calibration for V16 geometry scenario #36728, see HGCAL RecHits Calibration for V16 geometry scenario #36728 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge