Bugfix for DNN-based outside-in track seed generator for Muon HLT - Backport

[JanFSchulte]

Backport of bug fix for OI muon seeding introduced in #36587. This backport has been requested by the TSG coordinators (cc @silviodonato ).

[cmsbuild]

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_12_2_X.

It involves the following packages:

• RecoMuon/TrackerSeedGenerator (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Bugfix for DNN-based outside-in track seed generator for Muon HLT #36587

[slava77]

@cmsbuild please test

[slava77]

type bugfix

[slava77]

backport of #36587

[slava77]

cms/36597/slc7_amd64_gcc900/required Pending — Tests sched

it's been an hour already.
Is the jenkins blocked by some heavy processing or is there some more significant problem?
@smuzaffar @makortel

[makortel]

I have no clue, and I don't know @smuzaffar's availability (also not sure if @iarspider or @ddaina would be available and know more)

[davidlange6]

I've noticed the same - the PR tests didn't run any new PR for a day until this afternoon when then a few got picked up. Naively it seems the resources are busy -- some do seem in bad shape (eg, cmsbuild07, cmsbuild05) - not that I did an exhaustive search...

…

On Dec 28, 2021, at 5:02 PM, Matti Kortelainen ***@***.***> wrote: I have no clue, and I don't know @smuzaffar's availability (also not sure if @iarspider or @ddaina would be available and know more) — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d5df/21484/summary.html
COMMIT: 549b8b0
CMSSW: CMSSW_12_2_X_2021-12-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36597/21484/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250623
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250595
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #36597 549b8b0

• code changes are in line with the PR description; the code changes are the same as in Bugfix for DNN-based outside-in track seed generator for Muon HLT #36587. The modified TSGForOIDNN is not used in the standard (HLT) workflows at the moment. The backport should be OK.
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1