-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add processGUID() singleton, and use it in InputSource, StatisticsSenderService, and CondorStatusService #36570
Conversation
This will allow correlating information from the same process in different monitoring systems.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36570/27522
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a32b4/21426/summary.html Comparison SummarySummary:
|
@Dr15Jones Would this be better (than #36567) then? |
@makortel I think this looks better (since it is much simpler). |
+1 Any possible further adjustments (#36351 (comment)) can be done in a follow-up PR. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds
processGUID()
function to return a singletonedm::Guid
as a process-level GUID, and uses that in InputSource, StatisticsSenderService, and adds a new Chirp field for it in CondorStatusService. The GUID helps to correlate information in different monitoring systems that come from the same process.Resolves #36351.
PR validation:
Framework unit tests run.