Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processGUID() singleton, and use it in InputSource, StatisticsSenderService, and CondorStatusService #36570

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

makortel
Copy link
Contributor

PR description:

This PR adds processGUID() function to return a singleton edm::Guid as a process-level GUID, and uses that in InputSource, StatisticsSenderService, and adds a new Chirp field for it in CondorStatusService. The GUID helps to correlate information in different monitoring systems that come from the same process.

Resolves #36351.

PR validation:

Framework unit tests run.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36570/27522

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Services (core)
  • FWCore/Utilities (core)
  • Utilities/StorageFactory (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a32b4/21426/summary.html
COMMIT: 7412a0c
CMSSW: CMSSW_12_3_X_2021-12-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36570/21426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461688
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3461660
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

@Dr15Jones Would this be better (than #36567) then?

@Dr15Jones
Copy link
Contributor

@makortel I think this looks better (since it is much simpler).

@makortel
Copy link
Contributor Author

+1

Any possible further adjustments (#36351 (comment)) can be done in a follow-up PR.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 23, 2021

+1

@cmsbuild cmsbuild merged commit a4409ae into cms-sw:master Dec 23, 2021
@makortel makortel deleted the guidSingleton branch December 28, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correlate entries in monit_prod_cmssw_pop_* with those in monit_prod_condor_raw_metric*
4 participants