-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27303
|
A new Pull Request was created by @adewit for master. It involves the following packages:
@perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
I guess you do that because otherwise you would fall in the case in which genErrors are used when the CPE is called w/o track angles and there are none for bricked pixels. cmssw/RecoLocalTracker/SiPixelRecHits/python/PixelCPEGeneric_cfi.py Lines 54 to 56 in a4bb3ed
If that's the case might be worth specifying in the PR description. |
Yes, that is the reason. Have updated the PR description to be more specific about this. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27307
|
Pull request #36457 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9b732/21202/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27511
|
Pull request #36457 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
PR description:
This PR adds two new phase2 tracker layouts proposed in the IT sensors performance task force and correspond to evolutions of T27 (geometry with bricked pixels). More information [in these slides]
In particular this adds:
T28, a tracker based on T25, with 25x100 mum2 3D pixels in IT TBPX layer 1, bricked pixels in the central rod of TBPX layers 2 and 3, in the central 3 rods of TBPX layer 4, in TEPX, and in disks 5-8 of TFPX. The other pixels are planar 25x100 mum2.
T29, a tracker based on T25, with 25x100 mum2 3D pixels in IT TBPX layer 1, bricked pixels in the central rod of TBPX layers 2 and 3, in the central 3 rods of TBPX layer 4. 50x50 mum2 planar pixels are used in TFPX and TEPX.
There are no changes in the OT wrt T25.
T28 is included in geometry scenario 2026D89 and T29 in scenario 2026D90
important: we use process modifiers to account for the presence of bricked pixels, but no square pixel process modifiers are applied (even in T29). The reason for this is that with the square pixel process modifier the genErrors are used when running the CPE without track angles, but we do not have genErrors for bricked pixels.
@emiglior @tsusa @connorpa fyi
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport