-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FinalPath implementation [12_2] #36438
Conversation
This is needed for the FinalPath implementation.
Consolidated all common code used by OutputModuleBase classes into one class.
OutputModules on FinalPaths do not cause unscheduled execution.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_2_X. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test testCondToolsSiStripBuildersReaders had ERRORS Comparison SummarySummary:
|
The failure is unrelated to this PR. SQLite is reporting a disk I/O failure. |
For the record, this error (occurring also in IBs) is reported in #36319. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
PR description:
OutputModules placed on a FinalPath do not cause unscheduled execution. This ability was requested by HLT.
As part of work, consolidated all copied code used in various OutputModuleBase implementations into one class.
Backport of #36398
PR validation:
Code compiles. All framework related unit tests (included the newly added ones) pass.