Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PixelTrack SoA DQM monitoring #36432

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 9, 2021

PR description:

Follow-up to #36392:

PR validation:

Run runTheMatrix.py --what gpu -l 11634.506 on a lxplus-gpu node.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but it will be backported to 12_2_X together with #36392

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36432/27262

  • This PR adds an extra 16KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Dec 9, 2021

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Dec 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/SiPixelPhase1Heterogeneous (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5563d1/21123/summary.html
COMMIT: ff1be40
CMSSW: CMSSW_12_3_X_2021-12-09-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36432/21123/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19804
  • DQMHistoTests: Total failures: 1171
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 18633
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.914 KiB( 3 files compared)
  • DQMHistoSizes: changed ( 11634.506 ): 1.914 KiB SiPixelHeterogeneous/PixelTrackSoA
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250704
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 9, 2021

+1
Plots added and filled as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 10, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants