-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removal of last mentions of "HLTSchedule" #36395
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36395/27197
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @missirol, @jfernan2, @Martin-Grunewald, @slava77, @jpata, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f67e9/21061/summary.html Comparison SummarySummary:
|
+alca |
+1 |
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #35842. This PR removes the last mentions of the object "HLTSchedule".
The most important change is the removal of the internal renaming which was temporarily needed inside one of the customisations maintained by HLT.
The other changes are simply cleanup of
test/
configs that unnecessarily use the name "HLTSchedule" (these are cleanups I missed in #36073); please note that some of these configs are old, and already broken anyways for unrelated reasons; still, mentions toHLTSchedule
are removed, in the interest of clarity.Merely technical. No changes expected.
PR validation:
Unit-tests and
addOnTests
passed. Verified that the affectedtest/
configs continue to work if they were working already.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A
This is a cleanup PR, not a bugfix, so no backport to
12_2_X
is planned (could be done if that's preferred).