-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim LL fix missing ! in beam pipe radius check. #36324
FastSim LL fix missing ! in beam pipe radius check. #36324
Conversation
+1 |
Good spot. Let merge it at once, no need to test |
code-checks |
ping bot |
merge |
@smuzaffar , it seems thst everything got stuck here. |
I am checking |
code checks are running https://cmssdt.cern.ch/jenkins/job/run-pr-code-checks/27067/console , once done then bot will merge this PR |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36324/27067
|
A new Pull Request was created by @sbein (Sam Bein) for master. It involves the following packages:
can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thank you @smuzaffar ! |
Thank you @smuzaffar, @perrotta! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5586ba/20914/summary.html Comparison SummarySummary:
|
PR description:
A typo was introduced when implementing @perrotta's suggestion:
#36122
Thanks to Carlos Cid for spotting it almost instantly.