Fix the data type being passed to writeOneIOV in WritePPSAssociationCuts.cc

[wpcarvalho]

PR description:

This is a simple PR to correct the data type being passed to poolDbService->writeOneIOV in the module WritePPSAssociationCuts.cc.

As it currently is, the object stored in the database is of type PPSAssociationCutsconst*. The proposed fix allows to correctly save a object of type PPSAssociationCuts.

@fabferro @clemencia @sgrzegorz @jan-kaspar @grzanka

PR validation:

Local tests writing and retrieving data to a sqlite file using the tools in CondTools/CTPPS:

CondTools/CTPPS/test/write_PPSAssociationCuts_cfg.py
CondTools/CTPPS/test/retrieve_PPSAssociationCuts_cfg.py

After the fix, I was able to correctly retrieve the conditions data.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36291/26994

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @wpcarvalho (Wagner Carvalho) for master.

It involves the following packages:

• CondTools/CTPPS (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

type bug-fix

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-156528/20845/summary.html
COMMIT: 73de001
CMSSW: CMSSW_12_2_X_2021-11-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36291/20845/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+db

• part of DBouputService migration cms-AlCaDB/AlCaTools#28.
• consistent with PR description, tests are fine
• @wpcarvalho thanks for fixing this! A suggestion for a future PR: the unit test in

  cmssw/CondTools/CTPPS/test/test_CondToolsCTPPS.sh

  Lines 1 to 5 in d80a1fb

  	#!/bin/bash -ex
  	TEST_DIR=$CMSSW_BASE/src/CondTools/CTPPS/test
  	echo "test dir: $TEST_DIR"
  	cmsRun ${TEST_DIR}/write_PPSAssociationCuts_cfg.py

  could be improved to also read the .db file using CondTools/CTPPS/test/retrieve_PPSAssociationCuts_cfg.py so that you wouldn't have to do it manually yourself and it would be automatically tested.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[wpcarvalho]

Hi Francesco. Thanks for pointing it out!

• @wpcarvalho thanks for fixing this! A suggestion for a future PR: the unit test in

  cmssw/CondTools/CTPPS/test/test_CondToolsCTPPS.sh

  Lines 1 to 5 in d80a1fb

  	#!/bin/bash -ex
  	TEST_DIR=$CMSSW_BASE/src/CondTools/CTPPS/test
  	echo "test dir: $TEST_DIR"
  	cmsRun ${TEST_DIR}/write_PPSAssociationCuts_cfg.py

  
  could be improved to also read the .db file using CondTools/CTPPS/test/retrieve_PPSAssociationCuts_cfg.py so that you wouldn't have to do it manually yourself and it would be automatically tested.