Add labels to SiPixelFakeLorentzAngleESSource and SiPixelLorentzAngleReader

[mmusich]

PR description:

This is a follow-up to PR #36265. As there are different flavors (labels) of SiPixelLorentzAngleRcd (e.g. "forWidth" and "forAlignment") a label mechanism needs to be added to account for such cases.
I profit to enhance SiPixelLorentzAngleReader to deal with labels and to add a fillDescription method.

PR validation:

Unit tests, pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36283/26976

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36283/26976/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36283/26976/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36283/26977

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiPixelESProducers (alca)
• CondTools/SiPixel (db)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36283/26987

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #36283 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25b5f0/20841/summary.html
COMMIT: d991695
CMSSW: CMSSW_12_2_X_2021-11-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36283/20841/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3247845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• code changes in line with the PR description
• tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[Dr15Jones]

For future reference, all ESProducers (and ESSources) already have a mechanism to add a label, it is the configuration option
appendToDataLabel which is part of all ES modules.

[mmusich]

For future reference, all ESProducers (and ESSources) already have a mechanism to add a label, it is the configuration option appendToDataLabel which is part of all ES modules.

@Dr15Jones I noticed that here, but it was not clear to me what was the effect of it.
For example I see:

cmssw/Geometry/TrackerGeometryBuilder/plugins/TrackerDigiGeometryESModule.cc

Line 63 in 2ae8494

myLabel_(p.getParameter<std::string>("appendToDataLabel")),

but then in

cmssw/Geometry/TrackerGeometryBuilder/plugins/TrackerDigiGeometryESModule.cc

Line 66 in 2ae8494

auto cc = setWhatProduced(this);

the label is not passed as argument.
Is it sufficient to have a string parameter named appendToDataLabel in the configuration and the framework takes care of everything?
Also I can use the built-in mechanism if that's the preferred way, from the twiki linked above it is not clear if there's a preferred way.
Thanks

[Dr15Jones]

Is it sufficient to have a string parameter named appendToDataLabel in the configuration and the framework takes care of everything?

Yes.

Also I can use the built-in mechanism if that's the preferred way, from the twiki linked above it is not clear if there's a preferred way.

Either way is fine. I just wanted to point out no change was actually needed. The fillDescriptions is always great to have anyway.