[DQM] Fixed UnitTest crashes in ASAN

[jfernan2]

PR description:

This PR fixes 4 UnitTest crashes detected with ASAN in #36249 (comment)

Three of them are related to vectors being called with indexes beyond their size in clients of estDQMOnlineClient-*
The fourth, in TestDQMServicesDemo, was already detected in #36063 has been fixed by removing the ulimit request, which we are not sure why it ws here but the developer has left CMS more than year ago.

Validation: tested that UnitTests in ASAN run fine

[jfernan2]

test parameters:

• addpkg = DQM/Integration

[jfernan2]

please test with cms-sw/cmsdist#7469 for CMSSW_12_2_ASAN_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36269/26948

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36269/26948/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36269/26948/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

test parameters:

• addpkg = DQM/Integration

[jfernan2]

please test with cms-sw/cmsdist#7469 for CMSSW_12_2_ASAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36269/26949

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• DQM/DTMonitorClient (dqm)
• DQM/PixelLumi (dqm)
• DQMServices/Demo (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@barvic, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please abort

[jfernan2]

please test with cms-sw/cmsdist#7469 for CMSSW_12_2_ASAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfd814/20820/summary.html
COMMIT: cadde18
CMSSW: CMSSW_12_2_ASAN_X_2021-11-26-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36269/20820/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 71 failed jobs
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 1084160
• DQMHistoTests: Total nulls: 35
• DQMHistoTests: Total successes: 2163656
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.174 KiB( 41 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.533 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.246 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfd814/20850/summary.html
COMMIT: cadde18
CMSSW: CMSSW_12_2_X_2021-11-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36269/20850/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1