adjusting hltGetConfigution "minimal" event content to include the L1

[Sam-Harper]

PR description:

This PR adjusts the event content of the "minimal" output set by hltGetConfiguration to also include the L1. The L1 info is often useful to have to understand the HLT and I think its worth including it by default here.

PR validation:

Output using this option

Type                        Module                   Label      Process   
--------------------------------------------------------------------------
edm::TriggerResults         "TriggerResults"         ""         "SIM"     
BXVector<GlobalAlgBlk>      "hltGtStage2Digis"       ""         "HLT"     
BXVector<GlobalAlgBlk>      "simGtStage2Digis"       ""         "HLT"     
BXVector<l1t::EGamma>       "hltGtStage2Digis"       "EGamma"   "HLT"     
BXVector<l1t::EtSum>        "hltGtStage2Digis"       "EtSum"    "HLT"     
BXVector<l1t::Jet>          "hltGtStage2Digis"       "Jet"      "HLT"     
BXVector<l1t::Muon>         "hltGtStage2Digis"       "Muon"     "HLT"     
BXVector<l1t::Tau>          "hltGtStage2Digis"       "Tau"      "HLT"     
edm::TriggerResults         "TriggerResults"         ""         "HLT"     
trigger::TriggerEvent       "hltTriggerSummaryAOD"   ""         "HLT"     
BXVector<GlobalAlgBlk>      "hltGtStage2Digis"       ""         "HLTX"    
BXVector<GlobalAlgBlk>      "hltGtStage2ObjectMap"   ""         "HLTX"    
BXVector<l1t::EGamma>       "hltGtStage2Digis"       "EGamma"   "HLTX"    
BXVector<l1t::EtSum>        "hltGtStage2Digis"       "EtSum"    "HLTX"    
BXVector<l1t::Jet>          "hltGtStage2Digis"       "Jet"      "HLTX"    
BXVector<l1t::Muon>         "hltGtStage2Digis"       "Muon"     "HLTX"    
BXVector<l1t::Tau>          "hltGtStage2Digis"       "Tau"      "HLTX"    
edm::TriggerResults         "TriggerResults"         ""         "HLTX"    
trigger::TriggerEvent       "hltTriggerSummaryAOD"   ""         "HLTX"    

[Sam-Harper]

note I realised a small bug in the output content, will update it shortly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36260/26926

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Sam-Harper]

okay fixed it all (was fixed from the last message), the event output is

Type                        Module                   Label      Process   
--------------------------------------------------------------------------
edm::TriggerResults         "TriggerResults"         ""         "SIM"     
BXVector<GlobalAlgBlk>      "hltGtStage2Digis"       ""         "HLT"     
BXVector<GlobalAlgBlk>      "simGtStage2Digis"       ""         "HLT"     
BXVector<GlobalExtBlk>      "hltGtStage2Digis"       ""         "HLT"     
BXVector<l1t::EGamma>       "hltGtStage2Digis"       "EGamma"   "HLT"     
BXVector<l1t::EtSum>        "hltGtStage2Digis"       "EtSum"    "HLT"     
BXVector<l1t::Jet>          "hltGtStage2Digis"       "Jet"      "HLT"     
BXVector<l1t::Muon>         "hltGtStage2Digis"       "Muon"     "HLT"     
BXVector<l1t::Tau>          "hltGtStage2Digis"       "Tau"      "HLT"     
edm::TriggerResults         "TriggerResults"         ""         "HLT"     
trigger::TriggerEvent       "hltTriggerSummaryAOD"   ""         "HLT"     
BXVector<GlobalAlgBlk>      "hltGtStage2Digis"       ""         "HLTX"    
BXVector<GlobalAlgBlk>      "hltGtStage2ObjectMap"   ""         "HLTX"    
BXVector<GlobalExtBlk>      "hltGtStage2Digis"       ""         "HLTX"    
BXVector<l1t::EGamma>       "hltGtStage2Digis"       "EGamma"   "HLTX"    
BXVector<l1t::EtSum>        "hltGtStage2Digis"       "EtSum"    "HLTX"    
BXVector<l1t::Jet>          "hltGtStage2Digis"       "Jet"      "HLTX"    
BXVector<l1t::Muon>         "hltGtStage2Digis"       "Muon"     "HLTX"    
BXVector<l1t::Tau>          "hltGtStage2Digis"       "Tau"      "HLTX"    
edm::TriggerResults         "TriggerResults"         ""         "HLTX"    
trigger::TriggerEvent       "hltTriggerSummaryAOD"   ""         "HLTX"   

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fefca/20812/summary.html
COMMIT: 5eb112a
CMSSW: CMSSW_12_2_X_2021-11-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36260/20812/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36260/26969

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #36260 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fefca/20825/summary.html
COMMIT: b00d40f
CMSSW: CMSSW_12_2_X_2021-11-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36260/20825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1