-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored the ShieldingME4 and fixed all the MUON overlaps in muonYoke.xml #36234
Conversation
…he Muon System for 2026D86 Geometry
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36234/26864
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Thanks very much @slomeo By the way, why do you touch only |
Hi @srimanob
because if I understood well, I think that @bsunanda wants to do this job. @bsunanda , please let me know |
Please do not change Configuration/Geometry/python/dict,, and also please restore the old cmsExtendedGeometry2026D26XML_cfi.py. I am preparing the next version of scenario. |
OK, then I think we should do it in a cleaner way. For example,
|
ok @srimanob, probably it is better that this PR is related only to muonYoke.xml what do I have to do now? |
do I have to make a new "commit" without msExtendedGeometry2026D86.xml? I'm sorry but I don't understand because I never edited cmsExtendedGeometry2026D86XML_cfi.py as @bsunanda wrote. |
You can change back this file, |
ok |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36234/26870
|
Pull request #36234 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9b40/20745/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Restored the ShieldingME4 and fixed all the MUON overlaps in muonYoke.xml
A new version of muonYoke.xml is created (i.e 2026/v2/muonYoke.xml)
@bsunanda @ianna @cvuosalo @civanch @etcherniaev : FYI
PR validation:
validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsSimGeom-2026.root"
validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck2026_cfg.py >& overlaps.out &"
Muon's volumes are not present in the overlaps.out file.
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special