-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dependency for DQM/EcalMonitorTasks on DataFormats/Scalers for UBSAN #36191
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36191/26776
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb79b3/20642/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #35990 adds a dependency from DQM/EcalMonitorTasks to DataFormats/Scalers:
cmssw/DQM/EcalMonitorTasks/src/OccupancyTask.cc
Line 8 in 3908b5d
UBSAN builds need the typeinfo for LumiScalers. This PR adds that dependency to the BuildFile.xml to resolve the issue.
PR validation:
Without this fix, compilation in CMSSW_12_2_UBSAN_X_2021-11-19-2300 fails with the error
This PR error resolves the link error. This is a purely technical fix which should have no performance impact.