Python3 syntax upgrade

[conetthuerta]

PR description:

~/CMSSW_12_2_X_2021-11-17-1100/src/Validation/Geometry/test/MaterialBudget.py is updated;

• Syntax is upgraded from Python2 to Python3, this is necessary as per the migration to Python3 (MaterialBudget.py will not run without these changes in some versions of CMSSW_12).
• No dependency on any other PR's or externals.
• https://www.python.org/download/releases/3.0/

PR validation:

Tracker Material Budget Validation was run with CMSSW_12_2_X_2021-11-17-1100 (https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerMaterialBudgetValidation - TWiki needs to be updated), "Validation plots: single geometry configuration" were produced (.png and .pdf files that illustrate the tracker material budget, measured in fractional radiation lengths x or hadronic interaction lengths l, plotted as a function of eta, or phi, or R, or eta and phi, etc.).

• "Validation plots: single geometry configuration" cannot be produced when MaterialBudget.py is run in Python2 syntax in some versions of CMSSW_12 - upgrading to Python3 syntax is necessary.
• Relevant TWiki page (needs to be updated): https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerMaterialBudgetValidation

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36164/26715

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/Geometry/test/MaterialBudget.py modified in PR(s): Python3syntaxupgrade #36160

[cmsbuild]

A new Pull Request was created by @conetthuerta for master.

It involves the following packages:

• Validation/Geometry (geometry, dqm)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @apsallid, @lecriste, @ebrondol, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f478/20620/summary.html
COMMIT: d943844
CMSSW: CMSSW_12_2_X_2021-11-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36164/20620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3327156
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3327128
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[cvuosalo]

@conetthuerta What updates need to be made to the TrackerMaterialBudgetValidation twiki? Could you make those updates?

[conetthuerta]

@cvuosalo - yes, I can make those updates.
Instructions available on TrackerMaterialBudgetValidation TWiki will be updated to work post SLC6-CC7 migration (for CMS-SW10 and CMS-SW12).
The Catholic University of America (CUA) is going through the motions to have these updates up on TWiki ASAP.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1