Add online DQM plots for Run 3 L1T shower trigger

[zuoxunwu]

PR description:

Added L1T DQM module for CSC local shower and EMTF regional shower in the Run 3 trigger.

This DQM module is complete and tested with Run 3 MC samples.
As of CMSSW_12_2_0_pre2, there is an unpacker for CSC showers (PR#35461)but not for EMTF showers. Therefore at the moment the shower DQM cannot be used in data-taking and is not enabled in the online DQM sequence. It will be enabled once the EMTF shower unpacker is ready.
In this PR we do not expect any change in the output.

PR validation:

The DQM plots are tested with HTo2LongLivedTo4b samples and Neutrino gun samples.
Passed the unit test and matrix test as there should be no change in the output.
Code format changes are applied.

@dildick may want to watch this.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36128/26640

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

@zuoxunwu
Before moving onward, I have several questions/requests for you:

• please add yourself along with your github username in the comments section to the corresponding e-group in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#L1T
• I understand from the title of the PR that it is adding plots to ONline DQM, however the PR is in master and Online DQM is running on 12_0_X at present. Do you foresee to use this in current MWGR data taking? If so, we need a backport, but I understand unpacker is not ready yet
• You have tested the PR with MC, but if the plots to appear (once the unpacker is in) are for Online, it would eb nice to have some check on data and with some upload to a private Online DQM GUI to validate them

Thanks

[zuoxunwu]

@jfernan2 Thanks for the comments.

• I just added myself to the L1T online DQM developers.
• No we do not foresee using it in current test runs, and no backport is needed. The shower trigger is meant for Run 3 collision setup. At the moment the CSC is running with Run 2 firmware, and the Run 3 firmware is under development. The shower DQM will only be relevant when the Run 3 firmware is deployed.
• Ok sure. I think I can run on the zero-bias data in the recent pilot beam test and follow up in this thread.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d0bf1/20540/summary.html
COMMIT: d849c86
CMSSW: CMSSW_12_2_X_2021-11-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36128/20540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3320802
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3320780
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[zuoxunwu]

@jfernan2
I have run the shower DQM on a zero-bias test run (346512) and viewed it on a private DQM GUI. Everything worked well.
Most DQM plots for this run are empty, except the bins used for event counting. (This run is low energy and low pileup and we do not expect showers in muon chambers.) I am attaching a screenshot of my private DQM GUI.

Just as a reference, the plots on MC samples can be found in these slides.

Overall I think the shower DQM module works as intended and this PR can be merged. Let me know if you have further comments. Thanks!

[jfernan2]

Thank you very much @zuoxunwu !

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

(Please check that I did not add typos in the possible suggestions I'm writing here)

[zuoxunwu]

@perrotta Thanks for the suggestions and sorry for the late reply.
I have applied the changes following your suggestion.
Just as a validation, I tested it locally and everything worked fine.
This PR has been updated with the new commit.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36128/26747

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #36128 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d0bf1/20627/summary.html
COMMIT: ad54186
CMSSW: CMSSW_12_2_X_2021-11-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36128/20627/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3327156
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327134
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1