Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ input throttling (12_0_X) #35837

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

smorovic
Copy link
Contributor

Adding a mechanism to throttle processing using the input source when notified by the hltd daemon using a file marker.
This mechanism is implemented to have data safety and backpressure mechanism in DAQ with a limited size ramdisk now used as the output disk on HLT Filter Units.

We are planning to push this into production if possible during this week, so please review as soon as possible.

PR validation:
Tested in a small scale DAQ/HLT setup in CERN openstack.

This PR is a backport of #35833

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_12_0_X.

It involves the following packages:

  • EventFilter/Utilities (daq, reconstruction)

@jpata, @cmsbuild, @emeschi, @smorovic, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@smorovic
Copy link
Contributor Author

+daq

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-523a10/19920/summary.html
COMMIT: a31071e
CMSSW: CMSSW_12_0_X_2021-10-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35837/19920/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Oct 26, 2021

+reconstruction

for #35837 a31071e

  • code changes are outside of reco files (tcdsraw2digi) in the shared EventFilter/Utilities package
  • code changes are the same as in the master version DAQ input throttling (12_1_X) #35833

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Let have this switched off also in 12_0, even without waiting for the master IB which contains the same update, to speed up the build of 12_0_3_patch1: the update doesn't look harmful anyhow

@cmsbuild cmsbuild merged commit 09db298 into cms-sw:CMSSW_12_0_X Oct 26, 2021
This was referenced Oct 26, 2021
@smorovic smorovic deleted the 12_0_X_input_throttled branch August 24, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants