Phase2-hgx293 Try to resolve some issues for scintillator part of HGCal Geometry

[bsunanda]

PR description:

Try to resolve some issues for scintillator part of HGCal Geometry. It tries to remove the absent tiles in reconstruction geometry for V15 and V16. Also protects against the scintillator type in getting some corner parameters

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26160

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26160/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26160/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26161

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• Geometry/HGCalGeometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34afcb/19858/summary.html
COMMIT: b0dc745
CMSSW: CMSSW_12_1_X_2021-10-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35796/19858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751091
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[rovere]

Thanks, @bsunanda
I think the situation is much better now, with the PR integrated. In particular, I see no more errors related to Scintillator cells with completely overlapping corners.
The updated images of the full HGCAL detector obtained with this PR merged are available here.
As a comparison, the current default situation (i.e. w/o this PR merged) is visible here.
Clearly the structure of the Scintillator is visible with this PR merged.

NOTE: it seems to me, though, as if the outermost ring of Scintillators is completely missing. If I compare the images with what would be the expectation (obtained outside of CMSSW), available here, I see that the structures are identical but for the last ring, which is not there in the reconstruction geometry from CMSSW.

To see what I mean, I attach here the Scintillator part of Layer34: it should have 12 rings, it only has 11. The same -1 problem is present in all subsequent layers.

[rovere]

assign hgcal-dpg
FYI

[cmsbuild]

New categories assigned: hgcal-dpg

@felicepantaleo,@rovere,@pfs,@cseez you have been requested to review this Pull request/Issue and eventually sign? Thanks

[bsunanda]

@rovere I shall look into the missing outer ring of scintillators. Also there are issues of silicon layers (in particular partial wafers and rotated layers). I can investigate them once this and the other (#35765) are integrated and I have a fresh IB

[rovere]

Sure, thanks @bsunanda

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26243

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26243/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26243/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[bsunanda]

@perrotta I have taken care of your comment in this PR

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35796/26244

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35796 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cseez, @AdrianoDee, @srimanob, @rovere, @felicepantaleo, @pfs can you please check and sign again.

[bsunanda]

@civanch @cvuosalo @ianna @rovere @pfs @srimanob Can you sign this once again after fixing the report from static analyzer

[srimanob]

+Upgrade

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34afcb/19982/summary.html
COMMIT: fe2bc0c
CMSSW: CMSSW_12_1_X_2021-10-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35796/19982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-34afcb/11634.914_TTbar_14TeV+2021_DDDDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-34afcb/38634.0_TTbar_14TeV+2026D86+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 34213
• DQMHistoTests: Total nulls: 10
• DQMHistoTests: Total successes: 2867195
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• This PR was already fully signed before the last, very minor update/fix: let consider this PR as signed anyhow, then
• Merging it now, in order to allow it in pre5

[perrotta]

merge

[cvuosalo]

+1