Use shared_ptr for MutableMonitorElementData [12_0]

[Dr15Jones]

PR description:

Make sure DQMStore::localMEs_ never has stale pointer to the data.

This is a backport of #35756.

PR validation:

Code compiles. Simple test that had failed now runs fine. Also tested with valgrind.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_0_X.

It involves the following packages:

• DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Use shared_ptr for MutableMonitorElementData #35756

[Dr15Jones]

backport of #35756

[tvami]

type bug-fix

[tvami]

urgent

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b30ad4/19787/summary.html
COMMIT: 7f448ff
CMSSW: CMSSW_12_0_X_2021-10-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35757/19787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998542
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
As discussed in #35726 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@jfernan2 do you plan to sign also the master version of this PR, or do you see any counterindication for it?
@Dr15Jones : if we decide for this solution, following your evaluation, would you close #35751 and #35752 then?

[jfernan2]

@jfernan2 do you plan to sign also the master version of this PR, or do you see any counterindication for it?

Yes, just waiting for the Jenkins test to finish. Thanks!

[Dr15Jones]

@perrotta

if we decide for this solution, following your evaluation, would you close #35751 and #35752 then?

Yes.

[perrotta]

+1

• Already merged in the master PR, and succesfully tested in CMSSW_12_1_X_2021-10-21-2300